Generate SBOM and attest artifacts #629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
martincostello
commented
May 3, 2024
martincostello
commented
- Generate an SBOM for the Windows publish output.
- Attest the binaries and packages on Windows.
- Generate an SBOM for the Windows publish output. - Attest the binaries and packages on Windows.
martincostello
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 15 15
Lines 271 271
Branches 37 37
=======================================
Hits 265 265
Misses 3 3
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The action won't normalize apparently.
End with a slash.
Use the same syntax as elsewhere.
Try and fix wildcard not working.
Use the right terms.
Only attest the produced binaries, not other stuff.
Only important for the binaries, not also the tests etc.
Only attest when the packages are going to be pushed somewhere.
The NuGet packages get signed by NuGet.org, so validating the downloaded packages against the attestation won't succeed.
Attest provenance as well as via the SBOM.
Instead just use the provenance action.
Bump actionlint to 1.7.0 and remove workaround.
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.